Use combineCols for merging SCEs #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reformatting from precommit
sjspielman
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
This all looks fine to me, let's see how it goes!
I kept failures for different features, as I think that we may want to discuss what to do in the case of altExps with the same names but different feature sets: do we combine those or turn them into separately named altExps? I don't know yet, so failure seems the best option.
FYI -#248 (comment)
So this code does that, along with some linting/reformatting that precommit wanted.
Thank you for the reminder to locally set up my precommit hook in this repo!
|
|
||
| # ensure matching barcodes | ||
| colnames(sce_alt) <- colnames(sce) | ||
|
|
||
| # change feature names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #251, to hopefully fix the errors there.
So after fighting a bunch to try to see what we were missing, including some diving into the
cbindcode for SCEs, I decided to try a different approach, and let the developers of SCE handle our problem.Turns out they did a pretty good job. Using there combineCols function made things work and removed the need for us to create our own NA matrices!
This also removes the need for us to test that we have all the assays, as those get combined correctly. I kept failures for different features, as I think that we may want to discuss what to do in the case of altExps with the same names but different feature sets: do we combine those or turn them into separately named altExps? I don't know yet, so failure seems the best option.
So this code does that, along with some linting/reformatting that precommit wanted.
Locally, this is passing all tests, but we will get a final test when merging into #251!